DIA-624 add usnat to post choice #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilveirah
changed the base branch from
develop
to
DIA-2030_add_support_to_usnat
andresilveirah
requested review from
Nevazhnovu,
carmelo-iriti and
bohdan-go-wombat
15 tasks
| @@ -21,10 +21,15 @@ struct MetaDataResponse: Decodable, Equatable { | |||
| let sampleRate: Float | |||
| } | |||
| struct USNat: Decodable, Equatable { | |||
| let _id: String | |||
| let vendorListId: String | |||
There was a problem hiding this comment.
I'm gonna do the same
There was a problem hiding this comment.
@carmelo-iriti 👍 Keep in mind the API returns _id, I just thought it'd be more readable to change that internally to vendorListId.
carmelo-iriti
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.