Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA-3187 handle state consent strings #528

Conversation

andresilveirah
Copy link
Member

This PR has a little bit of extra code / refactoring than necessary for the feature:

  • rename MetaDataResponse.GDPR._id to vendorListId (unrelated to the feature)
  • change tests error message from error.failureReason (this is always nil) to error.description (unrelated to the feature)
  • call add applicableSections to MetaData.USNat response and call /consent-status if it changes.

@andresilveirah andresilveirah changed the base branch from develop to DIA-2030_add_support_to_usnat December 8, 2023 15:25
@andresilveirah andresilveirah mentioned this pull request Dec 8, 2023
15 tasks
Set to true if in the response of `/meta-data`, the applicableSections returned is different than the one stored.
Used as part of the decision to call `/consent-status`
*/
var needsNewUSNatData = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear solution

@andresilveirah andresilveirah merged commit b6d54a8 into DIA-2030_add_support_to_usnat Dec 8, 2023
@andresilveirah andresilveirah deleted the DIA-3187_handle_state_consent_strings branch December 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants