Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA-4459 integrate /choice/s from unified core_module #585

Merged
merged 15 commits into from
Dec 17, 2024

Conversation

Nevazhnovu
Copy link
Collaborator

@Nevazhnovu Nevazhnovu commented Nov 19, 2024

DIA-4459 [iOS] Integrate unified core

@Nevazhnovu Nevazhnovu marked this pull request as ready for review November 22, 2024 11:33
* Add core `reportIdfaStatus` post method

* Update naming

* Update naming
@Nevazhnovu Nevazhnovu changed the title DIA-4459 integrate unified core DIA-4459 integrate /choice/s from unified core_module Nov 25, 2024
)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the refactorings to both GET and POST requests, we won't need create the adapters for IncludeData (and its inner classes).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nevazhnovu maybe this can be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresilveirah I tried to delete it, but it doesn't work since in 0.0.10, postChoices demand IncludeData to be added to the Request object in initialization.

@Nevazhnovu Nevazhnovu merged commit f5aeb02 into develop Dec 17, 2024
7 checks passed
@Nevazhnovu Nevazhnovu deleted the DIA-4459-integrate-unified-core branch December 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants