implement error-metrics network call #10

andresilveirah · 2024-09-13T08:22:47Z

In this PR we:

implement the /custom-metrics network call
gather information about the device / os, depending on the platform
use that information in the call to /custom-metrics
"automatically" call /custom-metrics if:
- there's a network error (response.status != 2xx)
- the response body can't be parsed into the expected Body type

Nevazhnovu · 2024-09-17T11:27:24Z

core/src/commonMain/kotlin/com/sourcepoint/mobile_core/network/requests/DefaultRequest.kt

 import kotlinx.serialization.Serializable

+@Suppress("unused") // properties are used in every request inheriting from DefaultRequest


Thanks for comments 👍

Nevazhnovu · 2024-09-17T11:28:54Z

core/src/tvosTest/kotlin/network/DefaultRequestTest.kt

+    @Test
+    fun containsTheRightAttributes() = runTest {
+        val request = DefaultRequest()
+        assertEquals("mobile-core-tvOS", request.scriptType)


I'm not sure but tvOS should not be the default value?

Nevazhnovu · 2024-09-17T11:30:30Z

core/src/iosTest/kotlin/network/DefaultRequestTest.kt

+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+class DefaultRequestTest {


I suggest renaming or merging 2 classes with same name DefaultRequestTest

andresilveirah added 7 commits September 13, 2024 10:22

implement DeviceInformation class

0a74782

implement SPError class

2032b5a

refactor DeviceInformation and SPClient

6d0dafd

implement ErrorMetrics request

05d61b5

implement network errors logger

3c36109

fix linting

664c41d

implement request timeout

1062ebd

andresilveirah requested a review from Nevazhnovu September 16, 2024 12:53

Nevazhnovu approved these changes Sep 17, 2024

View reviewed changes

andresilveirah merged commit d53bcd7 into main Sep 18, 2024
2 checks passed

andresilveirah deleted the implement_error-metrics_call branch September 18, 2024 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement error-metrics network call #10

implement error-metrics network call #10

andresilveirah commented Sep 13, 2024 •

edited

Loading

Nevazhnovu Sep 17, 2024

Nevazhnovu Sep 17, 2024

Nevazhnovu Sep 17, 2024

		import kotlinx.serialization.Serializable

		@Suppress("unused") // properties are used in every request inheriting from DefaultRequest

implement error-metrics network call #10

implement error-metrics network call #10

Conversation

andresilveirah commented Sep 13, 2024 • edited Loading

Nevazhnovu Sep 17, 2024

Choose a reason for hiding this comment

Nevazhnovu Sep 17, 2024

Choose a reason for hiding this comment

Nevazhnovu Sep 17, 2024

Choose a reason for hiding this comment

andresilveirah commented Sep 13, 2024 •

edited

Loading