Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Store messages in BatchBuilder logic #1018

Merged

Conversation

orkunkilic
Copy link
Contributor

Description

This PR changes sov-ethereum logic.
Removes:

  • Sov-tx signing on RPC level
  • Auto batch building after every tx

Introduces:

  • Nonce initalization from storage
  • Sov-tx signing just before making a batch

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@orkunkilic orkunkilic marked this pull request as draft October 11, 2023 11:09
@orkunkilic orkunkilic marked this pull request as ready for review October 16, 2023 08:39
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkolad bkolad added this pull request to the merge queue Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1018 (bac8490) into nightly (32bc691) will increase coverage by 0.0%.
The diff coverage is n/a.

see 1 file with indirect coverage changes

Merged via the queue into Sovereign-Labs:nightly with commit bf68aff Oct 17, 2023
13 checks passed
@bkolad bkolad deleted the orkun/move-tx-signing-to-batch branch October 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants