Allow setting constants via manifest #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
#[config_constant]
attribute, which sets a constant from the manifest file. This functionality will be used in several places, but is blocking for the soft-confirmations workflow (where we need to set theinbox_delay
for forced transactions per-rollup instead of hard-coding it).This macro is exported from
sov_modules_api::macros
.N.B.: This PR only implements basic types (numeric types, strings, booleans, and arrays). Support for more complex types is left unimplemented for now.
Testing
A new test has been added using
trybuild
to ensure that valid values are produced for the covered types.Docs
A doc comment has been added