-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated ledger JSON-RPC crate #1032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
bkolad
reviewed
Oct 13, 2023
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
neysofu
force-pushed
the
filippo/rpc-lib-pr
branch
from
October 16, 2023 10:00
186ddab
to
98fc28e
Compare
bkolad
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 16, 2023
neysofu
added a commit
that referenced
this pull request
Oct 17, 2023
* Add sov-ledger-rpc Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Fixes Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Remove outdated comment Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Fix failing test Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Add docs to methods Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Fix optional dep issue Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Reuse hex rpc logic Signed-off-by: Filippo Costa <filippo@sovlabs.io> * Delete old template Cargo.toml Signed-off-by: Filippo Costa <filippo@sovlabs.io> --------- Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm introducing a new crate
full-node/sov-ledger-rpc
which has two components:jsonrpsee::RpcModule
builder for theLedgerDB
JSON-RPC API.RpcClient
.This results in some code deduplication across rollup crates, which can just import the server implementation to serve ledger data. The provided server implementation is also more extensive compared to what we had in
demo-rollup
, and exposes all getters thatLedgerRpcProvider
offers.rollup-template
has been modified accordingly.Testing
Existing
test_rpc.rs
indemo-rollup
, combined with new doc tests and two integration tests.