Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give preferred sequencer the ability to process "deferred blobs" early #1072

Merged
merged 32 commits into from
Oct 19, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR adds functionality to the BlobStorage module allowing the preffered_sequencer to request that some number of deferred_blobs be processed early.

As a reminder, blobs which are sent by someone other than the preferred sequencer are usually stored in state for some number of slots (DEFERRED_SLOTS_COUNT) before being processed. This is to ensure that they don't "front-run" the preferred sequencer, invalidating its soft confirmations.

This PR allows the preferred sequencer to specify a minimum number of such "deferred blobs" for the rollup to process during the next block. Note that this change does not allow the preferred sequencer to censor, since he can only set a lower bound on the number of deferred blobs to be processed. Deferred blobs will always be processed no later than DEFERRED_SLOTS_COUNT after appearing on the DA layer. If the preferred sequencer requests more blobs than are in the current deferred queue, the queue will be emptied.

Linked Issues

Testing

Tests have been added

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1072 (1853f65) into nightly (b94c95b) will decrease coverage by 0.1%.
The diff coverage is 81.0%.

Files Coverage Δ
...module-implementations/sov-blob-storage/src/lib.rs 98.3% <100.0%> (+0.8%) ⬆️
...-implementations/sov-sequencer-registry/src/lib.rs 98.3% <100.0%> (+0.3%) ⬆️
module-system/sov-modules-api/src/capabilities.rs 64.7% <0.0%> (-35.3%) ⬇️
...odule-implementations/sov-blob-storage/src/call.rs 53.3% <53.3%> (ø)
...plementations/sov-blob-storage/src/capabilities.rs 87.7% <84.0%> (-5.7%) ⬇️

... and 3 files with indirect coverage changes

@preston-evans98 preston-evans98 added this pull request to the merge queue Oct 19, 2023
Merged via the queue into nightly with commit 421e264 Oct 19, 2023
13 checks passed
@preston-evans98 preston-evans98 deleted the preston/soft-confirmations branch October 19, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants