-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give preferred sequencer the ability to process "deferred blobs" early #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
bkolad
reviewed
Oct 19, 2023
module-system/module-implementations/sov-blob-storage/src/capabilities.rs
Outdated
Show resolved
Hide resolved
bkolad
approved these changes
Oct 19, 2023
module-system/module-implementations/sov-blob-storage/src/capabilities.rs
Show resolved
Hide resolved
module-system/module-implementations/sov-blob-storage/src/capabilities.rs
Show resolved
Hide resolved
module-system/module-implementations/sov-sequencer-registry/src/lib.rs
Outdated
Show resolved
Hide resolved
module-system/module-implementations/sov-blob-storage/tests/capability_tests.rs
Show resolved
Hide resolved
citizen-stig
approved these changes
Oct 19, 2023
module-system/module-implementations/sov-blob-storage/src/capabilities.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to the
BlobStorage
module allowing thepreffered_sequencer
to request that some number ofdeferred_blobs
be processed early.As a reminder, blobs which are sent by someone other than the preferred sequencer are usually stored in state for some number of slots (
DEFERRED_SLOTS_COUNT
) before being processed. This is to ensure that they don't "front-run" the preferred sequencer, invalidating its soft confirmations.This PR allows the preferred sequencer to specify a minimum number of such "deferred blobs" for the rollup to process during the next block. Note that this change does not allow the preferred sequencer to censor, since he can only set a lower bound on the number of deferred blobs to be processed. Deferred blobs will always be processed no later than
DEFERRED_SLOTS_COUNT
after appearing on the DA layer. If the preferred sequencer requests more blobs than are in the current deferred queue, the queue will be emptied.Linked Issues
Testing
Tests have been added