Remove hack for prev_block_hash in Celestia genesis #553
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
approved these changes
Jul 25, 2023
citizen-stig
approved these changes
Jul 25, 2023
neysofu
force-pushed
the
preston/fix_celestia_hack
branch
from
fb71a22 to
b533688
Compare
|
I rebased to –hopefully– fix CI. |
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tendermint's
Hashtype is an enum with two variants:sha256orNone, whereNoneis only used by the Genesis block. This representation violates the Sovereign SDK's requirement that all blocks be uniquely identifiable by a [u8;32]. To fix it, we just need to hardcode a special "placeholder" hash for the genesis block.We had previously done this inside our
TmHashtype, but that type was missing block height information - so it could potentially be fooled into returning the placeholder for blocks other than the first. This PR fixes that issue.Linked Issues
Testing
I tested this using a local Celestia devnet to ensure that the hack worked if and only if the height was
1.