-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BlobReader interface #794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
neysofu
approved these changes
Sep 5, 2023
preston-evans98
added a commit
that referenced
this pull request
Sep 14, 2023
* Make BlobReaderTrait misuse resistant * Prevent advancing blob in zk mode * fix feature gate * Remove dead code * lint * Prevent nondeterminism in blob deserialization * fix celestia native feature * fix demo-simple-stf native * fix the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
BlobReaderTrait
looks almost identical tostd::io::Read
with a few extra methods for fetching blockchain-specific data. However, there significant differences in the way that the two traits are meant to be used. While thestd
reader is meant to be consumed only once, our readers are meant to be consumed twice - once by the prover and once by the verifier. This makes it very easy to introduce subtle bugs, such as consuming data in the host and forgetting to "reset" the reader before passing it to the guest.This PR changes the
BlobReader
API to make it more misuse resistant, and uses the new API to fix a bug in the old implementation.Fixes #456
Testing
This change is covered by existing unit tests.