Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement moduleAddress rpc method #796

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Conversation

preston-evans98
Copy link
Member

Description

Implement a moduleAddress rpc method for all modules

Linked Issues

Testing

Unit test coverage was added for the new method.

Docs

The rpc_gen macro doc comment has been updated

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #796 (7853b83) into nightly (777ce00) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Files Changed Coverage Δ
module-system/sov-modules-api/src/lib.rs 90.9% <ø> (ø)
module-system/sov-modules-macros/src/lib.rs 100.0% <ø> (ø)
...odule-system/sov-modules-macros/src/rpc/rpc_gen.rs 91.9% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

@preston-evans98 preston-evans98 added this pull request to the merge queue Sep 7, 2023
Merged via the queue into nightly with commit 1adbfc9 Sep 7, 2023
@preston-evans98 preston-evans98 deleted the preston/address-rpc branch September 7, 2023 08:12
preston-evans98 added a commit that referenced this pull request Sep 14, 2023
* Generate moduleAddress rpc method

* test

* fix doc test

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically implement get_Address query for each module RPC gen
2 participants