-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify ValidityCondition
and BlobTransaction
generics under DaSpec
. Remove SlotData
from STF API.
#838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
bkolad
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Question: Do we need to update rollup-interface/spec/interfaces/stf.md
doc as well?
Oh wow, yeah that's very out-of-date; it still uses begin/end slot and apply_block. |
preston-evans98
added a commit
that referenced
this pull request
Sep 14, 2023
…c`. Remove `SlotData` from STF API. (#838) * Switch ordering of witness * Feature gate native in stf runner * WIP: Fix chain-state signature. Done except for borsh * Fix all interfaces * lint; clippy * Move curr_hash to MockBlockHeader * lint * fix benches * add missing borrow * remove commented code * fix feature gating. Fix demo-prover * fmt demo prover * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes several improvements to the STF interface and related generics.
SlotData
trait inside the state machine. Replace such references withBlockHeader
andValidityCondition
as necessary.DaSpec
instead of aBlob
typeBlob
generic fromapply_slot
ValidityCondition
andBlobTransaction
and replace them with associated types on theDaSpec
Borsh
for values to be stored in state, and replace them withBcs
codecs.Fixes #621