Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: add missing todos & move eth_sendTransaction to sov-ethereum. #875

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 15, 2023

Description

This PR introduces the following changes:

  1. Moves eth_sendTransaction to sov-ethereum.
  2. Adds stub for eth_gasPrice
  3. Adds TODOs

Testing

CI passes.

Docs

No doc changes.

@bkolad bkolad marked this pull request as ready for review September 15, 2023 08:10
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #875 (b1f2caf) into nightly (ae50474) will increase coverage by 0.0%.
Report is 2 commits behind head on nightly.
The diff coverage is 42.8%.

Files Changed Coverage Δ
...system/module-implementations/sov-evm/src/query.rs 64.3% <0.0%> (+1.1%) ⬆️
full-node/sov-ethereum/src/lib.rs 91.4% <50.0%> (-1.5%) ⬇️
...-system/module-implementations/sov-evm/src/call.rs 94.6% <100.0%> (+<0.1%) ⬆️

... and 17 files with indirect coverage changes

@bkolad bkolad added this pull request to the merge queue Sep 15, 2023
Merged via the queue into nightly with commit c6f092b Sep 15, 2023
13 checks passed
@bkolad bkolad deleted the blaze/evm_issues_cleanup branch September 15, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants