Remove custom "demo-prover/guest" logic. Replace with StateTransitionVerifier.
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
approved these changes
Sep 20, 2023
citizen-stig
approved these changes
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two related changes. First, it removes all of the custom logic from the demo-prover guest crate and replaces it with a simple invocation of the StateTransitionVerifier. Second, it adds feature gating to the demo-rollup package to allow the
AppVerifier(StateTransitionVerifierof thedemo-stf) to be used inside of the guest environment. Along the way, this PR also fixes the feature gating of thestf-runnerpackage.