EVM: Implement SendTransaction and Storage access on RPC #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
reviewed
Sep 20, 2023
bkolad
reviewed
Sep 20, 2023
bkolad
reviewed
Sep 20, 2023
orkunkilic
changed the title
bkolad
reviewed
Sep 21, 2023
bkolad
reviewed
Sep 21, 2023
bkolad
reviewed
Sep 21, 2023
bkolad
reviewed
Sep 21, 2023
bkolad
reviewed
Sep 21, 2023
bkolad
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented eth_sendTransaction endpoint, as well as moving DevSigner to a custom feature flag called "local".
I have to implement custom signer on devsigner, as our entry types are coming from ethers and devsigner internally uses reth_primitives, there wasn't any correct encoding/decoding mechanism between them. It was more straightforward to implement another signer method but please let me know if you can think of a better solution.
I will merge common parts between eth_sendTransaction and eth_sendRawTransaction.
Linked Issues
eth_sendTransactionendpoint. #880 EVM: feature gateDevSigner&send_Transaction#839Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Integration tests are embedded. However during test the value set transaction successfully included in a block however state doesn't change!
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?