Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize genesis state form genesis files. #972

Merged
merged 25 commits into from
Oct 4, 2023
Merged

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 2, 2023

Description

This PR introduces the following chnages:

  1. Added genesis file for sov-sequencer-registry
  2. Implemented custom serde logic for CelestiaAddress and MockAddress.
  3. The genesis state is now read from files.

Linked Issues

Testing

CI passes.

Docs

No changes.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #972 (b6903e2) into nightly (306dc1f) will increase coverage by 0.1%.
The diff coverage is 97.4%.

Files Coverage Δ
adapters/celestia/src/verifier/address.rs 96.2% <100.0%> (+1.2%) ⬆️
...-implementations/sov-sequencer-registry/src/lib.rs 98.0% <100.0%> (+2.0%) ⬆️
...mplementations/sov-sequencer-registry/src/tests.rs 100.0% <100.0%> (ø)
rollup-interface/src/state_machine/mocks/da.rs 82.4% <94.7%> (+2.5%) ⬆️
...ystem/module-implementations/sov-bank/src/token.rs 81.3% <71.4%> (-0.6%) ⬇️

... and 1 file with indirect coverage changes

@bkolad bkolad changed the title WIP sequencer config Initialize genesis state form genesis files. Oct 4, 2023
@bkolad bkolad marked this pull request as ready for review October 4, 2023 11:27
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left two comments below.

The GenesisPaths pattern is a bit verbose, but can can remove it either with the discussed env. var. approach or with default path values, so it's not a big deal.

examples/demo-stf/src/genesis_config.rs Outdated Show resolved Hide resolved
@bkolad bkolad enabled auto-merge October 4, 2023 15:11
@bkolad bkolad added this pull request to the merge queue Oct 4, 2023
Merged via the queue into nightly with commit 7a05e1f Oct 4, 2023
12 checks passed
@bkolad bkolad deleted the blaze/seq_reg_config branch October 4, 2023 17:06
zvolin added a commit to eigerco/sovereign-sdk that referenced this pull request Oct 4, 2023
zvolin added a commit to eigerco/sovereign-sdk that referenced this pull request Oct 5, 2023
zvolin added a commit to eigerco/sovereign-sdk that referenced this pull request Oct 6, 2023
zvolin added a commit to eigerco/sovereign-sdk that referenced this pull request Oct 6, 2023
zvolin added a commit to eigerco/sovereign-sdk that referenced this pull request Oct 6, 2023
zvolin added a commit to zvolin/sovereign-sdk that referenced this pull request Oct 6, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2023
…p v1.0 (#997)

* chore: create a new docker compose setup with local celestia network

* feat: refactor celestia-adapter to use celestia-types

* feature guard celestia-rpc crate

* revert celestia-address changes from: Initialize genesis state form genesis files. (#972)

* switch to address from celestia-types

* cleanup, satisfy the clippy

* switch to celestia_types commitment generation

* Remove shares parsing

* don't try to translate EDS to shares

* treat extended data square as plain binary blobs, not shares

* Simplify dah validation

* Use namespaced shares for completeness proof

* rebase fixes

* Update test header.json

* Update celestia-node and celestia-tendermint

* Update test data for celestia adapter

* fix existing tests

* remove hex-literal dependency

* Add tests for txs verification

* fix linting

* Add protoc to the test workflow

* Allow Zlib licenses in dependencies

* Add protoc to the jobs where it was missing

* Update demo-rollup readme with the changes to local setup

* handle the case where amount of blobs is different than amount of proofs

* fix long running make start on the CI

* align prover benchmarks

* remove fuzzing namespace group creation from base64

* Update lockfiles

* Fix import

* Add protoc to doc tests

---------

Co-authored-by: Blazej Kolad <blazejkolad@gmail.com>
Co-authored-by: Preston Evans <preston.b.evans@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants