Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre_state_root in evm hook #986

Merged
merged 15 commits into from
Oct 9, 2023
Merged

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 5, 2023

Description

This PR introduces the following changes:

  1. Adds handling for the pre_state_root in begin_slot_hook.
  2. Refactors evm tests.

Fix #876

Testing

Ci passes.

Docs

No doch changes.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #986 (99639f3) into nightly (20c001a) will decrease coverage by 0.1%.
The diff coverage is 87.5%.

Files Coverage Δ
...system/module-implementations/sov-evm/src/hooks.rs 96.1% <100.0%> (+0.1%) ⬆️
...em/module-implementations/sov-evm/src/evm/tests.rs 97.3% <71.4%> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

@bkolad bkolad marked this pull request as ready for review October 9, 2023 06:25
@bkolad bkolad changed the title WIP Add pre_state_root in evm hook Add pre_state_root in evm hook Oct 9, 2023
@orkunkilic
Copy link
Contributor

LGTM!

@bkolad bkolad enabled auto-merge October 9, 2023 06:59
@bkolad bkolad added this pull request to the merge queue Oct 9, 2023
Merged via the queue into nightly with commit 367585e Oct 9, 2023
12 checks passed
@bkolad bkolad deleted the blaze/evm_begin_slot_hook_root_hash branch October 9, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM: Allow to access previous state_root and timestamp in begin_slot and genesis
3 participants