Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for dmo-stf. #998

Merged
merged 20 commits into from
Oct 9, 2023
Merged

Add docs for dmo-stf. #998

merged 20 commits into from
Oct 9, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 8, 2023 •
edited
Loading

Description

This PR introduces the following changes:

  1. Cleans up the code in demo-stf.
  2. Adds documentation to the demo-stf crate.
  3. Fixes the expose-rpc macro, which allows for the removal of duplicated Runtime definitions.

Linked Issues

Testing

Ci passes.

Docs

Docs updated.

@bkolad bkolad marked this pull request as draft October 8, 2023 11:37
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #998 (c32b3ea) into nightly (367585e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Files Coverage Δ
...le-system/sov-modules-macros/src/rpc/expose_rpc.rs 98.3% <100.0%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes

@bkolad bkolad changed the title WIP dmo-stf readme Add docs for dmo-stf. Oct 9, 2023
@bkolad bkolad marked this pull request as ready for review October 9, 2023 10:40
@bkolad bkolad requested a review from neysofu October 9, 2023 10:40
@bkolad bkolad enabled auto-merge October 9, 2023 12:39
@bkolad bkolad mentioned this pull request Sep 26, 2023
Open
@bkolad bkolad added this pull request to the merge queue Oct 9, 2023
Merged via the queue into nightly with commit 1c3f77f Oct 9, 2023
12 checks passed
@bkolad bkolad deleted the blaze/demo_stf_readme branch October 9, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubbelosix dubbelosix dubbelosix approved these changes

@neysofu neysofu Awaiting requested review from neysofu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkolad @dubbelosix