Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Apache 2 link leads to failed check #212

Merged
merged 5 commits into from
Dec 2, 2024
Merged

🐛 Apache 2 link leads to failed check #212

merged 5 commits into from
Dec 2, 2024

Conversation

jschoone
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
@cluster-stack-bot cluster-stack-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/github Changes made in the github directory labels Nov 29, 2024
@jschoone
Copy link
Contributor Author

Hi @chess-knight and @matofeder, could you quick have a look here? It looks like opensource.org denies requests, which leads to a failing check.
I just delete that now, what seems to work.

I also activated the pr-lint workflow for changes only on README.md like this PR.

@chess-knight
Copy link
Member

Hi @jschoone, this is really strange behaviour, because from my localhost everything works(make lint-links). Check also the .lychee.toml file where "https://opensource.org/license/apache-2-0/" is excluded(you have to adapt that problematic link to make the exclusion work), so I think it has good reason to be excluded. We can try to upgrade lychee to the latest, but I don't think it will help here much. I found a similar issue here lycheeverse/lychee#733. And also CAPH had to ignore it in syself/cluster-api-provider-hetzner#621.

Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
jschoone and others added 3 commits December 2, 2024 11:05
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
@jschoone
Copy link
Contributor Author

jschoone commented Dec 2, 2024

Hi @jschoone, this is really strange behaviour, because from my localhost everything works(make lint-links). Check also the .lychee.toml file where "https://opensource.org/license/apache-2-0/" is excluded(you have to adapt that problematic link to make the exclusion work), so I think it has good reason to be excluded. We can try to upgrade lychee to the latest, but I don't think it will help here much. I found a similar issue here lycheeverse/lychee#733. And also CAPH had to ignore it in syself/cluster-api-provider-hetzner#621.

Hi @chess-knight, thanks for the reply. Looks like it was a dot vs. dash typo and a missing slash. Should work now.

@jschoone jschoone requested a review from chess-knight December 2, 2024 10:13
@jschoone jschoone merged commit 9fe0282 into main Dec 2, 2024
9 checks passed
@jschoone jschoone deleted the jschoone-patch-1 branch December 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Changes made in the github directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants