Skip to content

Conversation

@jschoone
Copy link
Contributor

@jschoone jschoone commented Jun 4, 2025

What this PR does / why we need it:

This makes it possible to add more Block Devices to worker nodes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

…able

Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
@jschoone
Copy link
Contributor Author

jschoone commented Jun 4, 2025

Hi @garloff , the feature to add block devices can be tested with Cluster Stacks registry.scs.community/kaas/cluster-stacks:openstack-scs-1-32-v0-git-d1d35dc

Example Cluster definition, see the override at the end:

apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: my-cluster
  namespace: cluster
  labels:
    managed-secret: cloud-config
spec:
  clusterNetwork:
    pods:
      cidrBlocks:
      - "172.16.0.0/16"
    serviceDomain: cluster.local
    services:
      cidrBlocks:
      - "10.96.0.0/12"
  topology:
    class: openstack-scs-1-32-v0-git.d1d35dc
    controlPlane:
      replicas: 1
    version: v1.32.1
    workers:
      machineDeployments:
        - class: default-worker
          name: md-0
          replicas: 1
          variables:
            overrides:
            - name: additionalBlockDevices
              value:
              # Adds /dev/sdb with default 20GiB
              - name: data
              # Adds /dev/sdc with 50GiB
              - name: logs
                sizeGiB: 50

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature.
(Even though I suspect that typically worker nodes should NOT use this and storage needs rather be fulfilled by using PVs.)

@garloff
Copy link
Member

garloff commented Jun 6, 2025

Additional notes:

  1. Should there be some documentation?
  2. I tested it and it works like a charm.

@garloff garloff mentioned this pull request Aug 5, 2025
6 tasks
@garloff
Copy link
Member

garloff commented Sep 25, 2025

This was part of #232 and can thus be closed, no, @jschoone?

@jschoone
Copy link
Contributor Author

This was part of #232 and can thus be closed, no, @jschoone?

Yes, I'll close it

@jschoone jschoone closed this Sep 26, 2025
@jschoone jschoone deleted the feat/additionalBlockDevice branch September 26, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants