✨ Add basic auth option for the oci client #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chess-knight
added
the
Container
janiskemper
reviewed
Aug 1, 2024
Member
janiskemper
left a comment
janiskemper
left a comment
There was a problem hiding this comment.
looks good. But you need to fix the code, the linter complains!
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
chess-knight
force-pushed
the
publish-oci-basic-auth
branch
from
fbcf35e to
4bf773a
Compare
janiskemper
added a commit
that referenced
this pull request
Aug 27, 2024
* ✨ Implement publish command `csmctl publish` will generate the release similar to create command but additionally it will push the generated release to the oci repository. For this, we implemented the generic interface for assetsclients that we have in the CSO as well and that is fulfilled both by Github and OCI clients. Signed-off-by: janiskemper <janis.kemper@syself.com> * Add basic auth option for the oci client (#148) Signed-off-by: Roman Hros <roman.hros@dnation.cloud> --------- Signed-off-by: janiskemper <janis.kemper@syself.com> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.