✨ Refactor publish logic to support OCI remote and deduplicate code
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEiselt
changed the title
publish logic to support OCI remote and deduplicate code
DEiselt
changed the title
publish logic to support OCI remote and deduplicate codepublish logic to support OCI remote and deduplicate code
jschoone
force-pushed
the
159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted
branch
from
1519dea to
ac775e8
Compare
added: allow switch for assetclient in create command added: `--publish` flag for create command removed: unused code changes from last commit changed: moved `pushReleaseAssets` function to `create.go` removed: publish command and `publish.go` file changed: help text format chore: go mod tidy chore(create): reactivate validateHash fix: make linter happy Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
jschoone
force-pushed
the
159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted
branch
from
ac775e8 to
65e18de
Compare
…for-last-release-even-when-oci-is-wanted
jschoone
approved these changes
Oct 23, 2024
jschoone
deleted the
159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #159
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: