Skip to content

Conversation

@aniruddha2000
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #44

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
@kranurag7 kranurag7 force-pushed the ani-syself/issues/44 branch from 93a5567 to f99c60c Compare February 23, 2024 20:45
Copy link
Contributor

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good to me.

~/w/s/csctl (ani-syself/issues/44|✔) $ go build .
~/w/s/csctl (ani-syself/issues/44|✔) $ ./csctl create tests/cluster-stacks/docker/ferrol/ -o something
latest release found: "docker-ferrol-1-27-v2"
Bumped ClusterStack Version: v3
Bumped ClusterAddon Version: v3
NodeImage Version unchanged: v2
Created something/docker-ferrol-1-27-v3
~/w/s/csctl (ani-syself/issues/44|✔) $ ./csctl create tests/cluster-stacks/docker/ferrol/ -o hello
latest release found: "docker-ferrol-1-27-v2"
Bumped ClusterStack Version: v3
Bumped ClusterAddon Version: v3
NodeImage Version unchanged: v2
Created hello/docker-ferrol-1-27-v3
~/w/s/csctl (ani-syself/issues/44|✔) $ ./csctl create tests/cluster-stacks/docker/ferrol/
~/w/s/csctl (ani-syself/issues/44|✔) $ ./csctl create tests/cluster-stacks/docker/ferrol/
latest release found: "docker-ferrol-1-27-v2"
Bumped ClusterStack Version: v3
Bumped ClusterAddon Version: v3
NodeImage Version unchanged: v2
Created releases/docker-ferrol-1-27-v3

@kranurag7 kranurag7 merged commit ad4eac7 into main Feb 23, 2024
@kranurag7 kranurag7 deleted the ani-syself/issues/44 branch February 23, 2024 20:58
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Container Issues or pull requests relevant for Team 2: Container Infra and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub client code into the codebase to fetch the latest release from the github

4 participants