-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom zuul configs #433 #610
Conversation
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 1m 01s |
64ab047
to
6981925
Compare
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 18m 49s Warning: Sonobouy results=== Collecting results === time="2023-10-10T06:36:41Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-10-10T06:36:41Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-10-10T06:36:41Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7211 Passed: 5 Failed: 0 Skipped: 7206Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-10 06:36:47 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 19m 30s Warning: Sonobouy results=== Collecting results === time="2023-10-10T07:00:33Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-10-10T07:00:33Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-10-10T07:00:33Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7211 Passed: 5 Failed: 0 Skipped: 7206Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-10 07:00:39 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
a585dfb
to
dbff555
Compare
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
1a4d1a9
to
852185c
Compare
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 25m 43s Warning: Sonobouy results=== Collecting results === time="2023-10-19T14:30:56Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-10-19T14:30:56Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-10-19T14:30:56Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: systemd-logs Status: passed Total: 3 Passed: 3 Failed: 0 Skipped: 0Plugin: e2e Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 3 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-19 14:31:03 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 19m 29s Warning: Sonobouy results=== Collecting results === time="2023-10-19T15:09:04Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-10-19T15:09:04Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-10-19T15:09:04Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7211 Passed: 5 Failed: 0 Skipped: 7206Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-10-19 15:09:09 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM - just one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- just a minor suggestion for the docs
Signed-off-by: Filip Dobrovolny <dobrovolny.filip@gmail.com>
@matofeder @chess-knight Resolved ready to merge |
Adds the ability to change environment.tfvars from PR.