-
Notifications
You must be signed in to change notification settings - Fork 12
Add notes from old container workshop, so we can reference it. #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kurt Garloff <kurt@garloff.de>
|
Hey 👋, I would like to add/start the discussion about the standardized cluster resource: The goal now should be to implement a controller that watches the scs-cluster resources and convert them to gardener shoots and/or cluster-api clusters. Before we would go further with the controller development, I would like to give you a small demo and then we could talk about the next steps (better templating/more variables in the scs-cluster resource/support gridscale/...). Is this the way we should do it? |
|
Thanks Fynn, for sketching how to build the repo with kubebuilder. I also think that this is the way to go, since kubebuilder is used by most projects I know. It is definitely very handy that it creates the whole repo including controller template, API, and CRDs. In general, we are only left to implement the logic. However, I see one big issue with your approach: You have created ONE SCS controller for Cluster API (and, of course, one for Gardener). I'm not going to talk about the one for Gardener now, as it is not my specialty. CAPI has always general resources like the Cluster object that you create in the code. However, it has also the provider-specific objects (ProviderCluster, ProviderMachine, etc.). As every provider has its own objects, they should not all be created in just one operator. Otherwise, this operator would have to include all provider-specific code for all possible providers. Therefore, with just this one operator that you sketched, we won't be able to handle different Cluster API providers. We rather need a "library" to be able to write easily provider-specific SCS operators. |
|
Hey Janis, That's why I started the discussion, we have to collect all parameters (like we already did) and define custom resources we need (scs-cluster would be the root resource and we definitely need more custom resources like a "standardized" provider config). Would you agree @janiskemper @ALL |
|
Yes @fynluk I fully agree that we can start with the discussion about these parameters! So the first thing depends more on how to define a standardized API for any infrastructure provider and the second is more about how the architecture of the SCS lifecycle system looks like! We should continue this topic next week in the meeting. |
|
I really appreciate the discussion and progress! |
|
Still need a review to merge these aging minutes. |
Signed-off-by: Kurt Garloff kurt@garloff.de