-
Notifications
You must be signed in to change notification settings - Fork 28
Avoid CPU:Mem which confuses some markdown parsers. #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kurt Garloff <kurt@garloff.de>
depressiveRobot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a general problem? As there are many other places like "CPU:Mem" or "1:4". For example see scs-0100-v1-flavor-naming.md
mbuechse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would apply the same change to https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0103-v1-standard-flavors.md?plain=1#L135
I can do it (but I don't know when).
Signed-off-by: Kurt Garloff <kurt@garloff.de>
…dStack/standards into feat/flavor-mem-md-syntax
True, thanks for spotting! Done in @b105c8d. |
mbuechse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docusaurus is good for surprises. Thanks for resolving this!
Otherwise our CI will complain. Rightly so. Signed-off-by: Kurt Garloff <kurt@garloff.de>
|
@depressiveRobot: Did I address your concerns? If so, please re-review (and approve). |
depressiveRobot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks have passed. Looks good now to me :)
Cosmetic ...