Skip to content

Conversation

@garloff
Copy link
Member

@garloff garloff commented Nov 27, 2025

Cosmetic ...

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff garloff self-assigned this Nov 27, 2025
@garloff garloff added bug Something isn't working work in progress Pull requests that are work in progress, do not merge them standards Issues / ADR / pull requests relevant for standardization & certification labels Nov 27, 2025
Copy link
Contributor

@depressiveRobot depressiveRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a general problem? As there are many other places like "CPU:Mem" or "1:4". For example see scs-0100-v1-flavor-naming.md

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garloff
Copy link
Member Author

garloff commented Nov 28, 2025

I would apply the same change to https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0103-v1-standard-flavors.md?plain=1#L135 I can do it (but I don't know when).

True, thanks for spotting! Done in @b105c8d.

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docusaurus is good for surprises. Thanks for resolving this!

Otherwise our CI will complain. Rightly so.

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff
Copy link
Member Author

garloff commented Dec 2, 2025

@depressiveRobot: Did I address your concerns? If so, please re-review (and approve).

Copy link
Contributor

@depressiveRobot depressiveRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have passed. Looks good now to me :)

@mbuechse mbuechse merged commit d975b38 into main Dec 3, 2025
10 checks passed
@mbuechse mbuechse deleted the feat/flavor-mem-md-syntax branch December 3, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working standards Issues / ADR / pull requests relevant for standardization & certification work in progress Pull requests that are work in progress, do not merge them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants