Skip to content

Conversation

@ajfriesen
Copy link
Contributor

Here is my first draft regarding the version policy.

@ajfriesen ajfriesen requested a review from garloff January 16, 2023 10:44
@ajfriesen ajfriesen self-assigned this Jan 16, 2023
@ajfriesen ajfriesen linked an issue Jan 16, 2023 that may be closed by this pull request
9 tasks
@joshmue
Copy link
Contributor

joshmue commented Jan 16, 2023

Nice!

Right now, the record primarily concerns the speed of picking up new Kubernetes releases.

There are also a few other relevant topics, which may end up (a) not standardized, (b) in this record or (c) as a series of distinct records:

Support of non-current Kubernetes versions / pace of EOL-ing

What older releases is the provider required to support? All non-current "Minor" releases that are still supported upstream? Maybe more or less? Are patch releases treated differently?

Responsibilities provider vs. customer

Does the provider prepare version upgrades, but the customer triggers the upgrade on their schedule? Perhaps use another model for patch releases?

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document looks really good to me.
A few minor suggestions:
1.) Please add the DCO (Signed-Off-By) to your commit message, otherwise we can not merge the PR. git --amend -s and then force push (--force-with-lease) to the branch.
2.) A small section that says that there how long minor versions stay supported is subject to another Standard document. (The comment from Joshua is a good one, of course!)

@garloff
Copy link
Member

garloff commented Jan 19, 2023

@joshmue:

  • EOL'ing: I guess I would require providers to support minor versions at least as long as they are supported upstream. This thus means 14 months after 1.x.0 has been released acc. to current policies.) More is allowed, but customers probably should receive a warning.
    But let's take this one into the next team meeting.

  • Upgrade responsibility:

    • For self-managed clusters, the provider responsibility ends with registering the tested node image ...
    • For provider-managed clusters, I would expect customers having a variety of wishes:
      [ ] The ability to initiate rolling upgrades to new patches and to new minor versions manually (API call / gitops reconciliation)
      [ ] The ability to get notifications when clusters run outdated patchlevels or EOL'ed minor versions.
      [ ] The ability to opt-in for provider initiated patch-level upgrades soon after a new patch level is approved by the provider
      [ ] The ability to opt-in for provider-initiated minor version upgrade. As this has a real risk to break things, I would expect customers to only want this for non-productive clusters ...

    This is also to be discussed in the next team meeting.

@ajfriesen ajfriesen force-pushed the k8s-version-policy branch 2 times, most recently from 677f48c to 727b972 Compare January 23, 2023 09:56
@ajfriesen
Copy link
Contributor Author

We discussed that we want to create different ADR for the following topics:

  • How long do scs compliant providers need to support versions
  • Who does the upgrade of the cluster (user of that cluster or the provider or some mixed mode?)

@ajfriesen ajfriesen requested a review from garloff January 25, 2023 14:45
Signed-off-by: Andrej Friesen <andrej@gridscale.io>
We decided to create different ADR for the topic of deprecation
of kubernetes version and how long a provider has to keep a older
version available.

Signed-off-by: Andrej Friesen <andrej@gridscale.io>
garloff
garloff previously approved these changes Jan 26, 2023
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Kurt Garloff <kurt@garloff.de>
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still good.

@garloff garloff merged commit 1f5ec9b into main Jan 26, 2023
@garloff garloff deleted the k8s-version-policy branch January 26, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supported k8s versions

4 participants