Skip to content

Add Tests/scs-compatible-kaas.yaml #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbuechse merged 3 commits into from
Mar 6, 2024
Merged

Add Tests/scs-compatible-kaas.yaml #484

mbuechse merged 3 commits into from
Mar 6, 2024

Conversation

@mbuechse
Copy link
Contributor

@mbuechse mbuechse commented Feb 26, 2024

No description provided.

@mbuechse mbuechse added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Feb 26, 2024
@mbuechse mbuechse added this to the R6 (v7.0.0) milestone Feb 26, 2024
@mbuechse mbuechse self-assigned this Feb 26, 2024
cah-hbaum
cah-hbaum approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@cah-hbaum cah-hbaum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (saw too late thats its only draft for now...)

@mbuechse
Copy link
Contributor Author

mbuechse commented Feb 27, 2024

@cah-hbaum @garloff I think I will remove the CNCF k8s conformance test for the time being because it's kind of complicated to set up and it runs for 2 h -- see here: https://zuul.scs.community/t/SCS/build/b3a2d79f51994df599acf11085885f92/console
I think we should discuss in the relevant meetings how to incorporate this test into the certification, maybe for v2.

@mbuechse mbuechse force-pushed the feat/scs-compatible-kaas branch from 05b6018 to e8fb929 Compare February 28, 2024 22:04
@mbuechse
Copy link
Contributor Author

mbuechse commented Feb 28, 2024

@cah-hbaum To clear up a misunderstanding: this PR is not a draft PR, but the certificate scope is still in draft state (because it lacks stabilized_on). Still, this PR has to wait for #488 and #490 to make sense, so I might as well change it to a draft PR.

@mbuechse mbuechse marked this pull request as draft February 28, 2024 22:06
@mbuechse mbuechse changed the title Add Tests/scs-compatible-kaas.yaml (draft) Add Tests/scs-compatible-kaas.yaml Feb 28, 2024
@cah-hbaum
Copy link
Contributor

cah-hbaum commented Feb 29, 2024

Just rerequest a review from me after its really done (should be possible).

@cah-hbaum cah-hbaum mentioned this pull request Feb 29, 2024
Closed
3 tasks
@mbuechse mbuechse marked this pull request as ready for review February 29, 2024 19:17
@mbuechse mbuechse force-pushed the feat/scs-compatible-kaas branch from e8fb929 to 3943595 Compare February 29, 2024 19:18
martinmo
martinmo approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@martinmo martinmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But it needs a rebase or merge of main to actually be able to test it locally (because k8s_version_policy.py is missing in the branch).

Now only stabilized_at is missing =)

mbuechse added 3 commits March 6, 2024 13:34
@mbuechse
Add Tests/scs-compatible-kaas.yaml (draft)
292ba90 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Move CNCF k8s conformance to v2 for the time being
9c007e5 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Update to include prospective check tools
7cafe76 
This won't work without
- #488
- #490

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse mbuechse force-pushed the feat/scs-compatible-kaas branch from 3943595 to 7cafe76 Compare March 6, 2024 12:34
@mbuechse mbuechse merged commit 46bb2b8 into main Mar 6, 2024
@mbuechse mbuechse deleted the feat/scs-compatible-kaas branch March 6, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmo martinmo martinmo approved these changes

@cah-hbaum cah-hbaum cah-hbaum approved these changes

@jschoone jschoone Awaiting requested review from jschoone

@garloff garloff Awaiting requested review from garloff

Assignees

@mbuechse mbuechse

Labels

Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10

Projects

Sovereign Cloud Stack
Archived in project

Milestone

R6 (v7.0.0)

Development

Successfully merging this pull request may close these issues.

4 participants

@mbuechse @cah-hbaum @martinmo