Skip to content

Conversation

@martinmo
Copy link
Member

@martinmo martinmo commented Mar 5, 2024

While working on #488 I noticed several shortcomings in the text of the version policy standards scs-0210-v1 and scs-0210-v2, which this PR intends to fix.

I've split the commits to make it easier to review (hopefully), because some of them tackle only cosmetic issues and improve link sharing between the documents by making use of reference style Markdown links.

Most importantly, this PR intends to resolve the following ambiguities:

Furthermore, the conformance test section was outdated or missing in both standard versions and I fixed this.

martinmo added 9 commits March 5, 2024 15:51
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
@martinmo martinmo self-assigned this Mar 5, 2024
@martinmo martinmo requested review from cah-hbaum and mbuechse March 5, 2024 16:09
@mbuechse mbuechse added SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Mar 5, 2024
@mbuechse mbuechse added this to the R6 (v7.0.0) milestone Mar 5, 2024
Copy link
Contributor

@cah-hbaum cah-hbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice updates!

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like minor editorial improvements, nothing to write home about ;)
Nevertheless good work.
Only one issue: You removed the parts about the now-obsolete test for v1.
I think the sentence that this is now obsoleted (or rather superseded) by the new test is fine. But what about the old test? Did we remove it entirely? I'm not sure that this was a good call. Well, if that's the case, then so be it. Out of curiosity: would it be very hard to add a v1-mode to the new test script?

@martinmo
Copy link
Member Author

martinmo commented Mar 6, 2024

Seems like minor editorial improvements, nothing to write home about ;)

Exactly =)

Only one issue: You removed the parts about the now-obsolete test for v1. I think the sentence that this is now obsoleted (or rather superseded) by the new test is fine. But what about the old test? Did we remove it entirely?

Yes, I did in #488 and it was approved ;)

I'm not sure that this was a good call. Well, if that's the case, then so be it. Out of curiosity: would it be very hard to add a v1-mode to the new test script?

If it is important, I would prefer to just restore the old script which also lived in a separate directory. And of course I would revert the changes wrt conformance testing in the scs-0210-v1 text.

@mbuechse
Copy link
Contributor

mbuechse commented Mar 6, 2024

If it is important, I would prefer to just restore the old script which also lived in a separate directory. And of course I would revert the changes wrt conformance testing in the scs-0210-v1 text.

Maybe we restore it. We don't delete the standard, so let's also keep the test.

@martinmo martinmo force-pushed the feat/update-version-policy-standards branch from 933a567 to e63614b Compare March 6, 2024 14:29
@martinmo
Copy link
Member Author

martinmo commented Mar 6, 2024

Maybe we restore it. We don't delete the standard, so let's also keep the test.

I have created a separate PR #503 for restoring the test and reverted the change in scs-0210-v1 conformance test section here.

@martinmo martinmo changed the title Improve the K8s version policy standards scs-0210-v1 and scs-0210-v2 Minor editorial improvements to K8s version policy standards scs-0210-v1 and scs-0210-v2 Mar 6, 2024
@martinmo martinmo merged commit a58c601 into main Mar 6, 2024
@martinmo martinmo deleted the feat/update-version-policy-standards branch March 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants