-
Notifications
You must be signed in to change notification settings - Fork 28
Minor editorial improvements to K8s version policy standards scs-0210-v1 and scs-0210-v2 #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
cah-hbaum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice updates!
mbuechse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like minor editorial improvements, nothing to write home about ;)
Nevertheless good work.
Only one issue: You removed the parts about the now-obsolete test for v1.
I think the sentence that this is now obsoleted (or rather superseded) by the new test is fine. But what about the old test? Did we remove it entirely? I'm not sure that this was a good call. Well, if that's the case, then so be it. Out of curiosity: would it be very hard to add a v1-mode to the new test script?
Exactly =)
Yes, I did in #488 and it was approved ;)
If it is important, I would prefer to just restore the old script which also lived in a separate directory. And of course I would revert the changes wrt conformance testing in the scs-0210-v1 text. |
Maybe we restore it. We don't delete the standard, so let's also keep the test. |
This reverts commit 5686a8a. Signed-off-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>
933a567 to
e63614b
Compare
I have created a separate PR #503 for restoring the test and reverted the change in scs-0210-v1 conformance test section here. |
While working on #488 I noticed several shortcomings in the text of the version policy standards scs-0210-v1 and scs-0210-v2, which this PR intends to fix.
I've split the commits to make it easier to review (hopefully), because some of them tackle only cosmetic issues and improve link sharing between the documents by making use of reference style Markdown links.
Most importantly, this PR intends to resolve the following ambiguities:
Furthermore, the conformance test section was outdated or missing in both standard versions and I fixed this.