Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post "Contributing Upstream" #1011

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

osfrickler
Copy link
Contributor

No description provided.

@osfrickler osfrickler force-pushed the feat/blog-upstream-contribution branch 2 times, most recently from b427a9d to ecb4a8e Compare September 3, 2024 09:44
@osfrickler osfrickler requested a review from fkr September 3, 2024 11:31
author:
- "Dr. Jens Harbott"
avatar:
- "jhorstmann.jpg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was testing to fix the build error, will use the correct one for the next iteration

@fkr
Copy link
Member

fkr commented Sep 5, 2024

@osfrickler I'm already assigned for review but the state is still 'Draft'. Are you seeking feedback on the current state?

@osfrickler
Copy link
Contributor Author

Yes, Christian asked me to do so, I was assuming that he had already talked to you about this, that's why I didn't add some explaining comment.

There are some sections yet to be filled in, but what's there could stay as it is if people agree, so feedback on that would be welcome. I'll also push another update with more content later today.

@fkr fkr force-pushed the feat/blog-upstream-contribution branch from a4ee735 to 8e0f973 Compare September 9, 2024 08:35
@fkr
Copy link
Member

fkr commented Sep 9, 2024

This reads really well. I do think that the part about Release Engineering and TC could use some more elaboration - other than that, really good post.
I cherry-picked the fixes to the Readme (#1016) since they do not belong into this PR.

@osfrickler osfrickler force-pushed the feat/blog-upstream-contribution branch from 8e0f973 to 2ddf724 Compare September 16, 2024 09:19
@osfrickler osfrickler marked this pull request as ready for review September 17, 2024 13:07
@osfrickler osfrickler force-pushed the feat/blog-upstream-contribution branch from 2ddf724 to 146aa12 Compare September 18, 2024 06:16
@berendt
Copy link
Contributor

berendt commented Sep 18, 2024

@fkr This is ready and can be finalised.

@fkr
Copy link
Member

fkr commented Sep 19, 2024

Cool. Pushed to staging, when it is visible there, I'll do a last review.

@fkr fkr force-pushed the feat/blog-upstream-contribution branch from 146aa12 to b62f834 Compare September 19, 2024 11:08
Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
@berendt berendt force-pushed the feat/blog-upstream-contribution branch from b62f834 to 757ff7c Compare September 19, 2024 12:20
@fkr fkr merged commit 7c15301 into main Sep 19, 2024
5 of 6 checks passed
@fkr fkr deleted the feat/blog-upstream-contribution branch September 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants