Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep Rules] Add Unit Tests for pulling_ace/utils/subprocessor.py #43

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Nov 9, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

I created this PR to address this rule:

"Code should always include unit tests."

Description

This PR adds unit tests for the functions in the file pulling_ace/utils/subprocessor.py. The functions toxicity, promptinjection, riskcards, riskcard_wrapper, promptinjection_wrapper, toxicity_wrapper, and run_injections now have corresponding unit tests to ensure their correctness.

Summary of Changes

  • Added unit tests for the functions in pulling_ace/utils/subprocessor.py.
  • Created the file test/test_subprocessor.py to contain the unit tests.
  • Each function in pulling_ace/utils/subprocessor.py has a corresponding test function in test/test_subprocessor.py.
  • The unit tests cover the functionality of each function, including probe validation, command execution, and function calls.

Please review and merge this PR to ensure the reliability and correctness of the code in pulling_ace/utils/subprocessor.py.

Copy link
Contributor Author

sweep-ai bot commented Nov 9, 2023

Rollback Files For Sweep

  • Rollback changes to test/test_subprocessor.py

@sweep-ai sweep-ai bot added the sweep label Nov 9, 2023
Copy link
Contributor Author

sweep-ai bot commented Nov 9, 2023

Sandbox Executions

Copy link
Contributor Author

sweep-ai bot commented Nov 9, 2023

The command:
Run pipenv run black --check .
yielded the following error:
`##[error]Process completed with exit code 1.
##[group]Run docker build . -t pulling_ace:test
�[36;1mdocker build . -t pulling_ace:test�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 145B done
#1 DONE 0.0s

#2 [internal] load build definition from Dockerfile
#2 transferring dockerfile: 1.22kB done
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/library/python:3.10-slim
#3 ...

#4 [auth] library/python:pull token for registry-1.docker.io
#4 DONE 0.0s

#3 [internal] load metadata for docker.io/library/python:3.10-slim
#3 DONE 1.1s

#5 [internal] load build context
#5 transferring context: 252.52kB done
#5 DONE 0.0s

#6 [python-deps 1/7] COPY Pipfile Pipfile.lock /app/
#6 CACHED

#7 [python-deps 2/7] COPY . /app
#7 CACHED

#8 [python-deps 3/7] WORKDIR /app
#8 CACHED

#9 [python-deps 4/7] COPY pulling_ace /app/pulling_ace
#9 ERROR: failed to calculate checksum of ref 5ee0a90d-9ba7-4120-a52c-7d8898402fd7::bjiwm5fgpc3vvj2h9w6817fzk: "/pulling_ace": not found

#10 [base 1/1] FROM docker.io/library/python:3.10-slim@sha256:3c9182c6498d7de6044be04fb1785ba3a04f953d515d45e5007e8be1c15fdd34
#10 resolve docker.io/library/python:3.10-slim@sha256:3c9182c6498d7de6044be04fb1785ba3a04f953d515d45e5007e8be1c15fdd34 done
#10 sha256:3c9182c6498d7de6044be04fb1785ba3a04f953d515d45e5007e8be1c15fdd34 1.65kB / 1.65kB done
#10 sha256:9a5af4ca0c7678180db9bab26506d0f8959e5a6c32cc5349b7bdcd712790c0f3 1.37kB / 1.37kB done
#10 sha256:a9e021b7cfa1ac0b0cb401c04110e523878b46276735710ce120f940e9523700 6.94kB / 6.94kB done
#10 CANCELED

[python-deps 4/7] COPY pulling_ace /app/pulling_ace:


Dockerfile:19

17 |
18 | # Copy the pulling_ace directory into the Docker image
19 | >>> COPY pulling_ace /app/pulling_ace
20 |
21 | # Install pipenv and compilation dependencies

ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref 5ee0a90d-9ba7-4120-a52c-7d8898402fd7::bjiwm5fgpc3vvj2h9w6817fzk: "/pulling_ace": not found
##[error]Process completed with exit code 1.`
Here are the logs:

would reformat pulling_ace/cli.py
would reformat test/test_subprocessor.py
would reformat pulling_ace/utils/subprocessor.py

Oh no! 💥 💔 💥
3 files would be reformatted, 18 files would be left unchanged.

Copy link
Contributor Author

sweep-ai bot commented Nov 9, 2023

❌ Failed to make changes

Please join our Discord to report this issue.

@sweep-ai sweep-ai bot closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant