Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Engine Type to API #3

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Add Engine Type to API #3

merged 4 commits into from
Dec 26, 2024

Conversation

DEATHB4DEFEAT
Copy link

@DEATHB4DEFEAT DEATHB4DEFEAT commented Dec 23, 2024 •
edited
Loading

Added engine_type to /status and engine to /info

@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Dec 23, 2024
Merged
3 tasks
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Add Engine Type to /info Add Engine Type Dec 23, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Add Engine Type Add Engine Type to API Dec 23, 2024
Skyedra
Skyedra reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@Skyedra Skyedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just suggesting consistency with the variable name and not removing the comment basically

Robust.Server/ServerStatus/StatusHost.Handlers.cs Outdated Show resolved Hide resolved
Robust.Server/ServerStatus/StatusHost.Handlers.cs Outdated Show resolved Hide resolved
Robust.Shared/CVars.cs Outdated Show resolved Hide resolved
Robust.Shared/Utility/GameBuildInformation.cs Outdated Show resolved Hide resolved
Robust.Shared/Utility/GameBuildInformation.cs Outdated Show resolved Hide resolved
Robust.Shared/Utility/GameBuildInformation.cs Outdated Show resolved Hide resolved
Robust.Server/ServerStatus/StatusHost.Handlers.cs Show resolved Hide resolved
Skyedra
Skyedra approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@Skyedra Skyedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@Skyedra Skyedra merged commit 8d466d7 into Space-Station-Multiverse:master Dec 26, 2024
3 checks passed
Skyedra pushed a commit that referenced this pull request Dec 26, 2024
@DEATHB4DEFEAT @Skyedra
Add Engine Type to API (#3)
b412a97
DEATHB4DEFEAT added a commit to Simple-Station/SimpleStationLauncher that referenced this pull request Dec 30, 2024
@DEATHB4DEFEAT
Support Multiple Engines (#11)
5657e9f 
A step toward
#5 and
part of
#8.

- Multiverse auth (another PR)
- [x] Fix signature checks
- [x] Make the status endpoint changes not horrific
- [x] PR that to MV -
Space-Station-Multiverse/RobustToolbox#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skyedra Skyedra Skyedra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEATHB4DEFEAT @Skyedra