Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory.json #205

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update directory.json #205

merged 1 commit into from
Jul 15, 2022

Conversation

niccokunzmann
Copy link
Contributor

Hi,

I would like to add this endpoint that I am sitting at.

Greetings!

@s3lph
Copy link
Member

s3lph commented Jul 15, 2022

Hi @niccokunzmann, thanks for adding your space. Two points:

  • Your endpoint implements SpaceAPI v13, the current version is v14. Could you update your endpoint to support v14? Here is an HowTo. It's usually trivial to support both versions simultaneously.
  • raw.githubusercontent.com seems to set the wrong content type (text/plain instead of application/json). Shouldn't be an issue though, I'm not aware of any SpaceAPI clients rejecting APIs due to a wrong content type. If you want to fix this anyway, you'd need to move your endpoint to somewhere where the content type is set properly, e.g. Github Pages.

Apart from this, everything seems fine, and the validator is happy too.

Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@s3lph s3lph merged commit 5ee527a into SpaceApi:master Jul 15, 2022
@niccokunzmann niccokunzmann deleted the patch-1 branch July 15, 2022 15:10
@niccokunzmann
Copy link
Contributor Author

@s3lph thanks! I will track that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants