Fix diagonal line handling #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add special handling for diagonal lines to XAXIS in pixelateLineTouching.
blsemo
reviewed
Dec 2, 2019
|
Here you are Linux: Source DXF file Grid size: 0.2 As you can see the shapes are rendered differently and in case of Linux there are some holes when the segment is diagonal. I believe the difference between Linux and Mac OS comes from different locale settings and thus the coordinates are truncated to integers on Linux. |
|
I have truncated the coordinates manually and now the issue can be easily reproduced on any system. |
blsemo
approved these changes
Dec 5, 2019
pklampros
pushed a commit
that referenced
this pull request
Sep 2, 2020
Add special handling for diagonal lines to XAXIS in pixelateLineTouching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add special handling for diagonal lines to XAXIS in pixelateLineTouching.
It looks like due to some floating point inaccuracy diagonal lines get processed as XAXIS lines and result in non-watertight outline. I could not reproduce the issue on Mac however, I can reproduce it on Linux.