Allow the OpenGL window and related objects to use OpenGL ES #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ultimately allows the use of ANGLE for displaying graphics on windows, an implementation of OpengGL ES on directX. In practical terms the changes allow for using the depthmapX glview through Windows desktops without an OpenGL >=2.0 implementation, such as those through Remote Desktop (RDP) while previously the only solution was to switch to the legacy Map view. No special build or configuration parameters should be required, as the current Qt versions (>=5.5, tested on 5.13) dynamically load whatever graphics library is available. This change only affects the glview and not the 3dview (agents), as OpenGL ES does not support the fixed-function pipline (glBegin, glVertex etc.). Thus, glview should be available in both desktop and remote desktop versions of depthmapX, but the 3D view will only be available on local desktops that have a GPU. Other operating systems should are not affected by these changes More information: https://wiki.qt.io/Qt_5_on_Windows_ANGLE_and_OpenGL https://doc.qt.io/qt-5/windows-requirements.html#graphics-drivers https://en.wikipedia.org/wiki/OpenGL_ES https://doc.qt.io/qt-5/qopenglfunctions.html#details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ultimately allows the use of ANGLE for displaying graphics on windows, an implementation of OpengGL ES on directX. In practical terms the changes allow for using the depthmapX glview through Windows desktops without an OpenGL >=2.0 implementation, such as those through Remote Desktop (RDP) while previously the only solution was to switch to the legacy Map view. No special build or configuration parameters should be required, as the current Qt versions (>=5.5, tested on 5.13) dynamically load whatever graphics library is available. This change only affects the glview and not the 3dview (agents), as OpenGL ES does not support the fixed-function pipline (glBegin, glVertex etc.). Thus, glview should be available in both desktop and remote desktop versions of depthmapX, but the 3D view will only be available on local desktops that have a GPU. Other operating systems should are not affected by these changes.
Incidentally, this also fixes VirtualBox glview when the client is a Windows machine. 🥳
More information:
https://wiki.qt.io/Qt_5_on_Windows_ANGLE_and_OpenGL
https://doc.qt.io/qt-5/windows-requirements.html#graphics-drivers
https://en.wikipedia.org/wiki/OpenGL_ES
https://doc.qt.io/qt-5/qopenglfunctions.html#details
Relevant Travis build