Made fixes according to DeepScan. Unable to sign XPI

moz/options.js

@@ -179,7 +179,6 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 			'builtin_gostream',
 			'builtin_tubi',
 			'builtin_webtoplex',
-			'builtin_shanaproject',
 
 			// Plugins - End of file, "let plugins ="
 			'plugin_toloka',
@@ -1924,7 +1923,6 @@ let builtins = {
 	"Netflix": "https://netflix.com/",
 	"Verizon": "https://tv.verizon.com/",
 	"Trakt": "https://trakt.tv/",
-	"Shana Project": "https://shanaproject.com/",
 	"YouTube": "https://youtube.com/",
 	"Rotten Tomatoes": "https://rottentomatoes.com/",
 	"Fandango": "https://www.fandango.com/",

opa/options.js

@@ -158,7 +158,7 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 			'builtin_imdb',
 			'builtin_justwatch',
 			'builtin_letterboxd',
-			'builtin_metacritic',
+			// 'builtin_metacritic', // demoted - 01.18.2020 15:10 MST
 			'builtin_moviemeter',
 			'builtin_movieo',
 			'builtin_netflix',
@@ -182,7 +182,7 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 
 			// Plugins - End of file, "let plugins ="
 			'plugin_toloka',
-			'plugin_shanaproject',
+			// 'plugin_shanaproject', // promoted - 01.18.2020 15:10 MST
 			'plugin_myanimelist',
 			'plugin_myshows',
 			'plugin_indomovie',
@@ -192,6 +192,7 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 			'plugin_snagfilms',
 			'plugin_freemoviescinema',
 			'plugin_foxsearchlight',
+			'plugin_metacritic',
 
 			// Theme Settings
 			...(() => [...$('[data-option^="theme:"i]', true)].map(e => e.dataset.option))()
@@ -1927,7 +1928,6 @@ let builtins = {
 	"Netflix": "https://netflix.com/",
 	"Verizon": "https://tv.verizon.com/",
 	"Trakt": "https://trakt.tv/",
-	"Shana Project": "https://shanaproject.com/",
 	"YouTube": "https://youtube.com/",
 	"Rotten Tomatoes": "https://rottentomatoes.com/",
 	"Fandango": "https://www.fandango.com/",
@@ -1940,7 +1940,6 @@ let builtins = {
 	"Hulu": "https://hulu.com/",
 	"Flickmetrix": "https://flickmetrix.com/",
 	"TVDb": "https://thetvdb.com/",
-	"Metacritic": "https://www.metacritic.com/",
 	"ShowRSS": "https://showrss.info/",
 	"Vudu": "https://vudu.com/",
 	"Movieo": "https://movieo.me/",
@@ -1956,6 +1955,7 @@ let builtins = {
 	"Web to Plex": ["https://webtoplex.github.io/web/", "https://ephellon.github.io/web.to.plex/"],
 	"Allocine": "https://allocine.fr/",
 	"Plex": "https://app.plex.tv/",
+	"Shana Project": "https://www.shanaproject.com/",
 
 	// Dont' forget to add to the __options__ array!
 }, builtin_array = [], builtin_sites = {}, builtinElement = $('#builtin');
@@ -2062,7 +2062,6 @@ addListener($('#all-builtin'), 'click', event => {
 let plugins = {
 	'Indomovie': ['https://indomovietv.club/', 'https://indomovietv.org/', 'https://indomovietv.net/'],
 	'Toloka': 'https://toloka.to/',
-	'Shana Project': 'https://www.shanaproject.com/',
 	'My Anime List': 'https://myanimelist.net/',
 	'My Shows': 'https://myshows.me/',
 	'Redbox': 'https://www.redbox.com/',
@@ -2071,6 +2070,7 @@ let plugins = {
 	'SnagFilms': 'http://snagfilms.com/',
 	'Free Movies Cinema': 'https://freemoviescinema.com/',
 	'Fox Searchlight': 'http://foxsearchlight.com/',
+	'Metacritic': 'https://www.metacritic.com/',
 
 	// Don't forget to add to the __options__ array!
 }, plugin_array = [], plugin_sites = {}, pluginElement = $('#plugins');
@@ -2544,24 +2544,30 @@ Recall['@0sec'].SetVersionInfo = async() => {
 			status;
 
 		switch(compareVer(remote, local)) {
-			case 0:
-				status = 'same';
-				verEl.setAttribute('title', `The installed version is the most recent. No update required`);
-				break;
-
 			case -1:
 				status = 'high';
-				verEl.setAttribute('title', `The installed version is ahead of GitHub. No update required`);
+				verEl.setAttribute('title', `The installed version (v${ local }) is ahead of GitHub. No update required`);
+				break;
+
+			case 0:
+				status = 'same';
+				verEl.setAttribute('title', `The installed version (v${ local }) is the most recent. No update required`);
 				break;
 
 			case 1:
 				status = 'low';
 				verEl.href += (DM? '': '/latest');
-				verEl.setAttribute('title', `The installed version is behind GitHub. Update available`);
+				verEl.setAttribute('title', `The installed version (v${ local }) is behind GitHub. Update to v${ remote } available`);
 				break;
+
+			default:
+				verEl.setAttribute('title', `An error has occured comparing Web to Plex versions ([v${ local }] \u2194 [v${ remote }])`);
+				verEl.setAttribute('status', 'low');
+				verEl.innerHTML = 'ERROR';
+				return;
 		}
 
-		verEl.innerHTML = `v${ manifest.version }`;
+		verEl.innerHTML = `v${ local }`;
 		verEl.setAttribute('status', status);
 	}
 

src/options/index.js

@@ -179,7 +179,6 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 			'builtin_gostream',
 			'builtin_tubi',
 			'builtin_webtoplex',
-			'builtin_shanaproject',
 
 			// Plugins - End of file, "let plugins ="
 			'plugin_toloka',
@@ -1929,7 +1928,6 @@ let builtins = {
 	"Netflix": "https://netflix.com/",
 	"Verizon": "https://tv.verizon.com/",
 	"Trakt": "https://trakt.tv/",
-	"Shana Project": "https://shanaproject.com/",
 	"YouTube": "https://youtube.com/",
 	"Rotten Tomatoes": "https://rottentomatoes.com/",
 	"Fandango": "https://www.fandango.com/",

win/options/index.js

@@ -179,7 +179,6 @@ const storage = (chrome.storage.sync || chrome.storage.local),
 			'builtin_gostream',
 			'builtin_tubi',
 			'builtin_webtoplex',
-			'builtin_shanaproject',
 
 			// Plugins - End of file, "let plugins ="
 			'plugin_toloka',
@@ -1929,7 +1928,6 @@ let builtins = {
 	"Netflix": "https://netflix.com/",
 	"Verizon": "https://tv.verizon.com/",
 	"Trakt": "https://trakt.tv/",
-	"Shana Project": "https://shanaproject.com/",
 	"YouTube": "https://youtube.com/",
 	"Rotten Tomatoes": "https://rottentomatoes.com/",
 	"Fandango": "https://www.fandango.com/",