Add basic unreachable code detection #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs work, I'm making progress but I just realised a mistake I made in truthy evaluation and what I can do to fix it |
optimumtact
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Dec 10, 2019
About The Pull Request As detected by SpaceManiac/SpacemanDMM#123
MCterra10
pushed a commit
to austation/austation
that referenced
this pull request
Dec 10, 2019
About The Pull Request As detected by SpaceManiac/SpacemanDMM#123
spookydonut
force-pushed
the
brancheval
branch
from
3f71e61
to
1ea6d36
Compare
MCterra10
pushed a commit
to austation/austation
that referenced
this pull request
Dec 11, 2019
* Removes unreachable code (#48143) About The Pull Request As detected by SpaceManiac/SpacemanDMM#123 * Removes unreachable code
Cyberboss
reviewed
Jan 12, 2020
| self.returns = true; | ||
| } | ||
| if other.fuzzy { | ||
| self.returns = false; |
There was a problem hiding this comment.
loops basically
There was a problem hiding this comment.
you can't (yet) determine if a loop ran, so it's "fuzzy" if it can actually return and terminate the proc leaving the code below the loop unreachable.
This was referenced Jan 20, 2020
spookydonut
force-pushed
the
brancheval
branch
from
eb98a17
to
08bac62
Compare
|
I'm pretty happy with the state of this |
SpaceManiac
changed the title
spookydonut
force-pushed
the
brancheval
branch
from
08bac62
to
cb4a76a
Compare
spookydonut
force-pushed
the
brancheval
branch
from
cb5085b
to
28c263c
Compare
…nto brancheval # Conflicts: # src/dreamchecker/lib.rs
alexkar598
pushed a commit
to yogstation13/Yogstation
that referenced
this pull request
Apr 29, 2020
About The Pull Request As detected by SpaceManiac/SpacemanDMM#123
alexkar598
pushed a commit
to yogstation13/Yogstation
that referenced
this pull request
Apr 29, 2020
About The Pull Request As detected by SpaceManiac/SpacemanDMM#123
monster860
pushed a commit
to yogstation13/Yogstation
that referenced
this pull request
May 2, 2020
…2 in the process and updates dreamchecker(turdis) and casually fixes about 90 bugs in the codebase (#8324) * Cherry picks the unicode part 2 PR from TG * Things * drop 512 support * TAN --> tan * Manually does the things that was in renamed files * CLAMP --> clamp * ismovableatom -> ismovable * bugfixes, tg is bad * Ports sanitize_name * Bumps checks * Fixes new linter errors (#48126) About The Pull Request This fixes the errors raised by the new feature I'm adding to the linter: SpaceManiac/SpacemanDMM#119 * Update SpacemanDMM suite to 1.2 (#48785) * Update SpacemanDMM suite to 1.2 * Fix new lint errors * Removes unreachable code (#48143) About The Pull Request As detected by SpaceManiac/SpacemanDMM#123 * casually fixes 50 bugs * stoopid evil dreamchecker * stoopid evil dreamchecker * stoopid evil dreamchecker * almost the same thing * Makes all UIs UTF-8 * Fixes bugs * Fixes runtimes, some related to 513, some not * Fixes agent ids Co-authored-by: MrPerson <spamtaffic@gmail.com> Co-authored-by: alexkar598 <> Co-authored-by: spookydonut <github@spooksoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has some simple evaluation