Add off-by-default lint to forbid relative pathing #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceManiac
requested changes
Jan 21, 2020
src/dreammaker/config.rs
Outdated
| @@ -29,6 +30,14 @@ pub struct Langserver { | |||
| pub dreamchecker: bool, | |||
| } | |||
|
|
|||
| #[derive(Deserialize, Default, Debug, Clone)] | |||
| pub struct CodeStandards { | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
This probably belongs on the struct rather than on only one of the two field
src/dreammaker/objtree.rs
Outdated
| @@ -1008,7 +1014,7 @@ impl ObjectTree { | |||
| elems.len() + 1, | |||
| Default::default(), | |||
| Default::default(), | |||
| ) | |||
| ).and(Ok(())) | |||
There was a problem hiding this comment.
I would rather see (...)?; Ok(()) than this use of .and(), ditto below
src/dreammaker/config.rs
Outdated
| @@ -74,6 +83,10 @@ impl Config { | |||
| pub fn registerable_error(&self, error: &DMError) -> bool { | |||
| self.display.error_level.applies_to(error.severity()) | |||
| } | |||
|
|
|||
| pub fn code_standards(&self) -> &CodeStandards { | |||
| &self.code_standards | |||
There was a problem hiding this comment.
It's probably fine if this is a pub field but it's not that important either way
SpaceManiac
changed the title
SpaceManiac
approved these changes
Jan 22, 2020
SpaceManiac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148
This detects type definitions without a leading
/as relative though.