Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sleeping code under spawn() triggering SpacemanDMM_should_not_sleep #177

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Fix sleeping code under spawn() triggering SpacemanDMM_should_not_sleep #177

merged 4 commits into from
Jul 3, 2020

Conversation

Cyberboss
Copy link
Contributor

@Cyberboss Cyberboss commented Apr 9, 2020 •
edited by SpaceManiac
Loading

Fixes #175

spookydonut
spookydonut requested changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@spookydonut spookydonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing spawns in should not sleep i feel defeats the purpose of the lint but making it a config option to disable this would be ok

SpaceManiac
SpaceManiac approved these changes Jul 3, 2020
View reviewed changes
Copy link
Owner

@SpaceManiac SpaceManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lean towards thinking of spawn as more of a addtimer type call that happens to be builtin - it doesn't put the current call stack on hold, so it's not "sleeping" for purposes of the lint. In that lens this seems OK

@SpaceManiac SpaceManiac merged commit 36e69a3 into SpaceManiac:master Jul 3, 2020
@SpaceManiac SpaceManiac changed the title Fixes sleeping code under spawn() triggering SpacemanDMM_should_not_sleep Fix sleeping code under spawn() triggering SpacemanDMM_should_not_sleep Jul 3, 2020
@SpaceManiac SpaceManiac added this to the suite v1.5 milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spookydonut spookydonut spookydonut requested changes

@SpaceManiac SpaceManiac SpaceManiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
suite v1.5
Development

Successfully merging this pull request may close these issues.

should_not_sleep checks detect sleeps in calls from spawn blocks
3 participants
@Cyberboss @SpaceManiac @spookydonut