Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check child overrides when checking for pure/sleep violations #204

Closed
wants to merge 2 commits into from
Closed

Check child overrides when checking for pure/sleep violations #204

wants to merge 2 commits into from

Conversation

spookydonut
Copy link
Collaborator

@spookydonut spookydonut commented Aug 12, 2020 •
edited by SpaceManiac
Loading

Fixes #203

@SpaceManiac SpaceManiac changed the title Make dreamchecker check child overrides when checking for pure/sleep … Check child overrides when checking for pure/sleep violations Aug 12, 2020
SpaceManiac
SpaceManiac requested changes Sep 5, 2020
View reviewed changes
Copy link
Owner

@SpaceManiac SpaceManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is far, far too slow to be practical. I got tired of waiting for /tg/ to check after about 20 minutes.

@spookydonut
Copy link
Collaborator Author

This implementation is far, far too slow to be practical. I got tired of waiting for /tg/ to check after about 20 minutes.

well fuck

@spookydonut spookydonut closed this Oct 7, 2020
@spookydonut spookydonut mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceManiac SpaceManiac SpaceManiac requested changes

Assignees
No one assigned
Labels
dreamchecker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHOULD_NOT_SLEEP does not check overrides of procs being called for sleeps
2 participants
@spookydonut @SpaceManiac