Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Should not sleep" to catch world.Export and world.Import #216

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Fix "Should not sleep" to catch world.Export and world.Import #216

merged 4 commits into from
Oct 10, 2020

Conversation

spookydonut
Copy link
Collaborator

Fixes #208

SpaceManiac
SpaceManiac requested changes Oct 9, 2020
View reviewed changes
Copy link
Owner

@SpaceManiac SpaceManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also test doesn't pass

src/dreamchecker/lib.rs Outdated
| "alert"
| "shell"
| "winexists"
| "winget" if self.inside_newcontext == 0) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: the if guard doesn't depend on the pattern, so it should probably go outside the matches!() invocation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

@SpaceManiac SpaceManiac changed the title Fixes "Should not sleep" does not catch world.Export or world.Import Fix "Should not sleep" to catch world.Export and world.Import Oct 10, 2020
@SpaceManiac SpaceManiac merged commit 66c3c90 into SpaceManiac:master Oct 10, 2020
@SpaceManiac SpaceManiac added this to the suite v1.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceManiac SpaceManiac SpaceManiac requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
suite v1.7
Development

Successfully merging this pull request may close these issues.

"Should not sleep" does not catch world.Export or world.Import
2 participants
@spookydonut @SpaceManiac