Add warning for return x in spawn context
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
reviewed
Nov 5, 2020
| @@ -1281,6 +1281,11 @@ impl<'o, 's> AnalyzeProc<'o, 's> { | |||
| }, | |||
| Statement::Return(Some(expr)) => { | |||
| // TODO: factor in the previous return type if there was one | |||
| if self.inside_newcontext > 0 { | |||
There was a problem hiding this comment.
IIRC isn't this also set in waitfor = 0 procs?
There was a problem hiding this comment.
I don't think so, the only place that changes inside_newcontext to non-zero values seems to be the Statement::Spawn match arm.
spookydonut
changed the title
return x in spawn contextreturn x in spawn context
j-awn
pushed a commit
to j-awn/SpacemanDMM
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know doing
return somethingin aspawncontext is always equivalent to just returning without a value and as such it is probably a mistake so let's warn people about it.