-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
514 builtins support #240
514 builtins support #240
Conversation
will think on this one but I suspect it will end up being a new |
also clean up of speedy table
Thanks for the PR. Can punt on |
@@ -434,6 +453,7 @@ pub fn register_builtins(tree: &mut ObjectTree) { | |||
proc/get_step_rand(Ref); | |||
proc/get_step_to(Ref,Trg,Min=0); | |||
proc/get_step_towards(Ref,Trg); | |||
proc/gradient(Gradient, index); // unsure how to handle (Item1, Item2, ..., index) form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious on if there's a proper way to address the two forms at once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, but it really only affects the popup parameter list completion, so it hasn't been a priority
@@ -376,7 +394,7 @@ pub fn register_builtins(tree: &mut ObjectTree) { | |||
alpha, color, infra_luminosity, layer, maptext_width, maptext_height, | |||
maptext_x, maptext_y, luminosity, pixel_x, pixel_y, pixel_w, pixel_z, | |||
transform, dir, icon, icon_state, invisibility, maptext, suffix, appearance, | |||
dir, radius, | |||
dir, radius, space, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: if space
is specified, color
must be as well - potential linting/testing in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible feature for the in-depth filter()
verifier
|
||
// 514 stuff | ||
|
||
generator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be nice to have an enum for the various type
s, and the applicable defines for rand being an enum as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how to handle the operator overloads for this either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the existence of operator overloads for builtins isn't currently described by SpacemanDMM
|
||
generator; | ||
generator/proc/Rand(); | ||
generator/proc/Turn(a); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also a weird operator_turn in relation to this
no idea how we're going to support |
Don't know if you want to put this based on a 514 branch or something, for full support. Here's the bulk of the work done for the builtins though. - gradient() - animate(space) // weird form - rgb(space) // weird form - rgb2num() - filter(type="bloom") - load_resource() - splicetext() - list.Splice() - time2text() - world.timezone - client.timezone - ||= - &&= - world.movement_mode + enums - := walrus/assign-into/expression assign - world.map_cpu - particles/ - generator/ - embedded winget syntax // don't think we need to add anything - mouse actions // don't think we need to add anything note: uncovered http://www.byond.com/forum/post/2652280 Tested the produced executable: ![image](https://user-images.githubusercontent.com/4741640/106538107-8d2 58480-64b0-11eb-9d65-0020229647d7.png)
Don't know if you want to put this based on a 514 branch or something, for full support. Here's the bulk of the work done for the builtins though.
note: uncovered http://www.byond.com/forum/post/2652280
notes:
shorter entries be first,
but it is unclear what it means by shorter - might mean sub-string length (if that's even the right word)?Tested the produced executable: