Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection of sleeping client procs #252

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

spookydonut
Copy link
Collaborator

@spookydonut spookydonut commented Mar 10, 2021

MeasureText() and SoundQuery() technically sleep/block.

Fixes #236

@spookydonut spookydonut merged commit 42163b5 into SpaceManiac:master Mar 11, 2021
@@ -1873,6 +1874,23 @@ impl<'o, 's> AnalyzeProc<'o, 's> {
}
}

fn check_type_sleepers(&mut self, ty: TypeRef<'o>, location: Location, unscoped_name: &Ident) {
println!("{}, {}", ty, unscoped_name);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Garbage on stdout will kill the langserver. You can use eprintln!() to avoid this problem (or delete this line since it's just debugging junk)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops

j-awn pushed a commit to j-awn/SpacemanDMM that referenced this pull request Apr 1, 2021
* This should work but doesn't.

* bugfix maybe?

* working now
@SpaceManiac SpaceManiac added this to the suite v1.7 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.SoundQuery() should trigger sleep lint
2 participants