Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the scope operator #367

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

LemonInTheDark
Copy link
Contributor

Adds support for :: to the parser, in all its forms (global proc/var, off type)
Also implements behavior for it. We'll properly read the type of what we attach to, and double check that everything matches. Works for the proc refs too.

I've added unit tests for all this to double check my work. I DIDN'T mirror the static var detection byond does. problem for another day.

Please let me know if the way I'm going about this is silly/mislead, I'll declutter as directed

Adds support for :: to the parser, in all its forms (global proc/var,
off type)
Also implements behavior for it. We'll properly read the type of what we
attach to, and double check that everything matches.
Works for the proc refs too.

I've added unit tests for all this to double check my work.
I DIDN'T mirror the static var detection byond does. problem for another
day.

Please let me know if the way I'm going about this is silly/mislead,
I'll declutter as directed
@LemonInTheDark
Copy link
Contributor Author

Fails to error on non existing vars, workin on it

@LemonInTheDark LemonInTheDark marked this pull request as draft October 3, 2023 05:35
…sed is processed

Also adds support for dumping ALL errors, just to ensure we see it all
at once
@LemonInTheDark
Copy link
Contributor Author

I tell a lie, it works fine

@LemonInTheDark LemonInTheDark marked this pull request as ready for review October 4, 2023 01:05
@SpaceManiac SpaceManiac merged commit 2b3d30b into SpaceManiac:master Oct 20, 2023
@SpaceManiac SpaceManiac added this to the suite v1.8 milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants