Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements /proc/final, piped into should not override #369

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

LemonInTheDark
Copy link
Contributor

As a part of this we need to make a struct when building proc defs, to keep track of their flags AND their kind at the same time.

We then pass that down into a new flags var on the proc decl struct, and we're golden

Only thing of note is I removed the is_private and is_protected vars from proc declerations because they were totally unused. Spooky added em a long time ago and I think it was for not much reason

As a part of this we need to make a struct when building proc defs, to
keep track of their flags AND their kind at the same time.

We then pass that down into a new flags var on the proc decl struct, and
we're golden

Only thing of note is I removed the is_private and is_protected vars
from proc declerations because they were totally unused. Spooky added em
a long time ago and I think it was for not much reason
@LemonInTheDark LemonInTheDark marked this pull request as draft October 5, 2023 02:44
@LemonInTheDark
Copy link
Contributor Author

Fixing proc return types, please hold

@LemonInTheDark
Copy link
Contributor Author

Moved the as syntax stuff to #370, this is all clear

@LemonInTheDark
Copy link
Contributor Author

sorry accidentally killed your commit, it's still built in tho. had trouble with two different locals and forgot which had most recent changes.

@SpaceManiac SpaceManiac merged commit 61165ec into SpaceManiac:master Oct 18, 2023
@SpaceManiac SpaceManiac added this to the suite v1.8 milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants