Implement %%, %%=, and operator"" #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The float stuff was easy. Operator was too, just took a bit to realize how it worked Nothin much else to say, outside that I needed to roll my own operation for this one, since float remainder is kinda hard to find (and I couldn't after cursory reading)
LemonInTheDark
force-pushed
the
icecream-float
branch
from
0a10a78
to
c2a23e1
Compare
LemonInTheDark
changed the title
SpaceManiac
requested changes
Oct 8, 2023
crates/dreammaker/src/parser.rs
Outdated
| @@ -944,6 +950,8 @@ impl<'ctx, 'an, 'inp> Parser<'ctx, 'an, 'inp> { | |||
| } else { | |||
| last_part.push_str("[]"); | |||
| } | |||
| } else if self.exact(Punct(EmptyQuote))?.is_some() { | |||
There was a problem hiding this comment.
A less shocking change might be to look for an empty Token::String here.
There was a problem hiding this comment.
handled, I think?
SpaceManiac
changed the title
SpaceManiac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The float stuff was easy. Operator was too, just took a bit to realize how it worked
Nothin much else to say, outside that I needed to roll my own operation for this one, since float remainder is kinda hard to find (and I couldn't after cursory reading)