ARM64 native binaries for MacOS #190

zbx1425 · 2023-07-14T13:38:06Z

Description

This PR attempts to finish #112 by merging it with the latest upstream updates and trying tofix the build scripts.
Now the CI script can produce correct binary files. I have yet to test if these native binaries built actually works currently though.

Type of change

Minor changes or tweaks (quality of life stuff)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

kusaanko · 2023-08-18T07:57:38Z

I don't think this has a problem.
I built this repository and published it to my local maven repository.
Then I run the example code on my test gradle project. It works with arm64 JVM.
I tested it on M2 MacBook Air.

manmaor · 2023-09-02T07:30:23Z

@SpaiR Hi, could you please merge this PR, It will be greatly appreciated, Much obliged, Maor.

eclogues · 2023-09-04T21:46:24Z

Excitedly waiting for this to be merged.

LawrenceB5477 · 2023-10-06T23:39:56Z

Any update on this? Trying to use imgui on my m1

OlshaMB · 2023-10-14T14:52:18Z

@SpaiR what's stopping this pr?

b7011343 · 2023-10-23T16:39:51Z

@SpaiR I too would like to know what's stopping this PR

OlshaMB · 2023-10-24T21:14:47Z

I think the branch needs to be merged with new changes, but apart from that i don't see any issues.

Not related to the pr

I came to this pr because it prevents me from playing minecraft with [axiom](https://axiom.moulberry.com/), I had to provide the libs by path.

I think if the author won't merge someone should maintain the fork and release the mac m-series version, this fork should also have a guide for providing the forked version to a java program. At the moment, I am too busy.

OlshaMB · 2023-10-24T21:16:44Z

@zbx1425 Could you merge or give rights to @b7011343 or me to the fork, so we wouldn't have to make an another pr

zbx1425 · 2023-10-25T01:52:30Z

I think if the author won't merge someone should maintain the fork and release the mac m-series version, this fork should also have a guide for providing the forked version to a java program. At the moment, I am too busy.

I see there's workflows in the repo for releasing built bindings and natives to maven. But I'm new to gradle and maven, so I'd appreciate helps on getting it working on forked repository.

realRobotix · 2023-11-10T14:54:30Z

@zbx1425 i've forked your fork, merged changes from upstream and setup the workflows to publish to my maven repo: https://maven.realrobotix.me/#/imgui-java/io/github/spair
https://github.com/realRobotix/imgui-java
would be nice if someone could test the macos artifacts the build produced

bionicode · 2023-11-16T14:17:04Z

would be nice if someone could test the macos artifacts the build produced

Wow, this works! Thanks!!! @realRobotix. I'm on an M1 MacBook Pro running Sonoma.

realRobotix

@zbx1425 you merged some code which is specific for publishing to my maven, which shouldn't be included in the merge request

.github/workflows/ci.yml

publish.gradle

buildSrc/scripts/publish.sh

b7011343 · 2023-11-20T13:44:24Z

How do I use this dependency in a gradle project? I know i have to point it at the maven repo but I keep having build errors

bionicode · 2023-11-20T20:26:05Z

How do I use this dependency in a gradle project? I know i have to point it at the maven repo but I keep having build errors

This worked for me.

project.ext.lwjglVersion = "3.3.3"
project.ext.lwjglNatives = "natives-macos-arm64"

repositories {

maven {
    name "realrobotixImguiJava"
    url "https://maven.realrobotix.me/imgui-java"
}

mavenCentral()

}

dependencies {

// Imgui fork at real robotix
implementation "io.github.spair:imgui-java-app:1.86.11-10-g0dbf36c"
implementation "io.github.spair:imgui-java-natives-macos-ft:1.86.11-10-g0dbf36c"

// LWJGL
implementation platform("org.lwjgl:lwjgl-bom:$lwjglVersion")

implementation "org.lwjgl:lwjgl"
implementation "org.lwjgl:lwjgl-glfw"
implementation "org.lwjgl:lwjgl-opengl"
runtimeOnly "org.lwjgl:lwjgl::$lwjglNatives"
runtimeOnly "org.lwjgl:lwjgl-glfw::$lwjglNatives"
runtimeOnly "org.lwjgl:lwjgl-opengl::$lwjglNatives"

}

b7011343 · 2023-11-21T22:46:27Z

I am getting build errors with the following build.gradle


repositories {
//    mavenLocal()

    maven {
        name "realrobotixImguiJava"
        url "https://maven.realrobotix.me/imgui-java"
    }

    mavenCentral()
}

project.ext.lwjglVersion = "3.3.3"
project.ext.jomlVersion = "1.10.5"
project.ext.imguiVersion = "1.82.2"

switch (OperatingSystem.current()) {
    case OperatingSystem.LINUX:
        def osArch = System.getProperty("os.arch")
        project.ext.lwjglNatives = osArch.startsWith("arm") || osArch.startsWith("aarch64")
                ? "natives-linux-${osArch.contains("64") || osArch.startsWith("armv8") ? "arm64" : "arm32"}"
                : "natives-linux"
        break
    case OperatingSystem.MAC_OS:
        project.ext.lwjglNatives = System.getProperty("os.arch").startsWith("aarch64") ? "natives-macos-arm64" : "natives-macos"
        break
    case OperatingSystem.WINDOWS:
        def osArch = System.getProperty("os.arch")
        project.ext.lwjglNatives = osArch.contains("64")
                ? "natives-windows${osArch.startsWith("aarch64") ? "-arm64" : ""}"
                : "natives-windows-x86"
        break
}

project.ext.lwjglNatives = "natives-macos-arm64"

dependencies {
    implementation platform("org.lwjgl:lwjgl-bom:$lwjglVersion")

    ['', '-opengl', '-glfw'].each {
        implementation "org.lwjgl:lwjgl$it:$lwjglVersion"
        implementation "org.lwjgl:lwjgl$it::natives-windows"
    }

    implementation "io.github.spair:imgui-java-binding:$imguiVersion"
    implementation "io.github.spair:imgui-java-lwjgl3:$imguiVersion"

    implementation "io.github.spair:imgui-java-natives-windows:$imguiVersion"
    implementation "io.github.spair:imgui-java-natives-windows-x86:$imguiVersion"
    implementation "io.github.spair:imgui-java-natives-linux:$imguiVersion"
    implementation "io.github.spair:imgui-java-natives-linux-x86:$imguiVersion"
//    implementation "io.github.spair:imgui-java-natives-macos:$imguiVersion"
    implementation "io.github.spair:imgui-java-natives-macos-ft:1.86.11-10-g0dbf36c"
    implementation "io.github.spair:imgui-java-app:1.86.11-10-g0dbf36c"
//    implementation "io.github.spair:imgui-java-natives-macos:1.86.11-10-g0dbf36c"
//    implementation "io.github.spair:imgui-java-natives-macosarm64"

    implementation "org.lwjgl:lwjgl"
    implementation "org.lwjgl:lwjgl-assimp"
    implementation "org.lwjgl:lwjgl-glfw"
    implementation "org.lwjgl:lwjgl-nfd"
    implementation "org.lwjgl:lwjgl-openal"
    implementation "org.lwjgl:lwjgl-opengl"
    implementation "org.lwjgl:lwjgl-stb"
    runtimeOnly "org.lwjgl:lwjgl::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-assimp::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-glfw::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-nfd::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-openal::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-opengl::$lwjglNatives"
    runtimeOnly "org.lwjgl:lwjgl-stb::$lwjglNatives"
    implementation "org.joml:joml:${jomlVersion}"

Error


Exception in thread "main" java.lang.IllegalStateException: Failed to compile shader:
ERROR: 0:1: '' :  #version required and missing.
ERROR: 0:1: '330' : syntax error: syntax error

        at imgui.gl3.ImGuiImplGl3.createAndCompileShader(ImGuiImplGl3.java:463)
        at imgui.gl3.ImGuiImplGl3.createShaders(ImGuiImplGl3.java:313)
        at imgui.gl3.ImGuiImplGl3.createDeviceObjects(ImGuiImplGl3.java:272)
        at imgui.gl3.ImGuiImplGl3.init(ImGuiImplGl3.java:127)
        at jcw.jge2d.engine.gui.ImGuiLayer.initImGui(ImGuiLayer.java:233)
        at jcw.jge2d.engine.gui.Window.init(Window.java:187)
        at jcw.jge2d.engine.gui.Window.run(Window.java:117)
        at jcw.jge2d.Main.main(Main.java:9)

Christoffyw · 2023-12-18T15:07:14Z

Would be nice if this was merged.

Displee · 2024-05-06T12:44:10Z

Can this be merged?

# Conflicts: # bin/freetype/imgui-java64.dll # bin/imgui-java64.dll

zly2006 · 2024-05-14T05:06:24Z

@SpaiR I have reverted some unnecessary changes so it could be merged, and the example app works fine for me, but there is still something to do:

Docs
Rebuild binaries (after merged)

phraktle · 2024-07-04T14:20:23Z

@SpaiR It would be great to get this (or #223 if that's better) merged and released (since the @realRobotix maven repo is not functional).

realRobotix · 2024-07-04T14:45:42Z

@SpaiR It would be great to get this (or #223 if that's better) merged and released (since the @realRobotix maven repo is not functional).

sorry for the inconvenience, i have identified the issue with the maven it should be up again in a few minutes

SpaiR · 2024-08-04T21:39:58Z

Closing in favor of #223
I'll mention this PR in changelog as well. Thanks for the contrib! 🙏

Tom-Ski and others added 3 commits July 14, 2023 20:24

m1 support

a52e689

separate arm from 'mac' in GHA matrix

f37c45f

Fix MacOS builds

14b970f

SpaiR added the feat New feature or request label Jul 17, 2023

SpaiR force-pushed the main branch from eb2b285 to 1288f11 Compare September 29, 2023 09:47

b7011343 approved these changes Oct 23, 2023

View reviewed changes

realRobotix and others added 3 commits November 10, 2023 12:38

Merge changes

2fafd7a

[ci skip] update native binaries

2185a45

Setup my maven repo

0dbf36c

[ci skip] Fix missing environment variables

bdf3fc2

realRobotix suggested changes Nov 17, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

publish.gradle Outdated Show resolved Hide resolved

buildSrc/scripts/publish.sh Outdated Show resolved Hide resolved

felouataoui mentioned this pull request Jan 24, 2024

Bug: Library not found for Arch64 #165

Closed

rexfleischer mentioned this pull request Feb 19, 2024

build(binding): MacOS ARM64 native binaries #223

Merged

5 tasks

fix(ci): install FreeType on both x64 and arm64

b9b79ea

zly2006 added 4 commits May 14, 2024 12:51

Merge branch 'refs/heads/main' into zbx-fork

e2805d4

# Conflicts: # bin/freetype/imgui-java64.dll # bin/imgui-java64.dll

revert: upstream

ac0521c

revert: upstream

988c588

revert: upstream

9b30e55

SpaiR closed this Aug 4, 2024

SpaiR mentioned this pull request Aug 6, 2024

Universal macOS ARM64 binary and statically compiled FreeType #239

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM64 native binaries for MacOS #190

ARM64 native binaries for MacOS #190

zbx1425 commented Jul 14, 2023

kusaanko commented Aug 18, 2023 •

edited

Loading

manmaor commented Sep 2, 2023

eclogues commented Sep 4, 2023

LawrenceB5477 commented Oct 6, 2023

OlshaMB commented Oct 14, 2023

b7011343 commented Oct 23, 2023

OlshaMB commented Oct 24, 2023

OlshaMB commented Oct 24, 2023

zbx1425 commented Oct 25, 2023 •

edited

Loading

realRobotix commented Nov 10, 2023

bionicode commented Nov 16, 2023

realRobotix left a comment

b7011343 commented Nov 20, 2023

bionicode commented Nov 20, 2023

b7011343 commented Nov 21, 2023

Christoffyw commented Dec 18, 2023

Displee commented May 6, 2024

zly2006 commented May 14, 2024

phraktle commented Jul 4, 2024

realRobotix commented Jul 4, 2024

SpaiR commented Aug 4, 2024

ARM64 native binaries for MacOS #190

ARM64 native binaries for MacOS #190

Conversation

zbx1425 commented Jul 14, 2023

Description

Type of change

kusaanko commented Aug 18, 2023 • edited Loading

manmaor commented Sep 2, 2023

eclogues commented Sep 4, 2023

LawrenceB5477 commented Oct 6, 2023

OlshaMB commented Oct 14, 2023

b7011343 commented Oct 23, 2023

OlshaMB commented Oct 24, 2023

OlshaMB commented Oct 24, 2023

zbx1425 commented Oct 25, 2023 • edited Loading

realRobotix commented Nov 10, 2023

bionicode commented Nov 16, 2023

realRobotix left a comment

Choose a reason for hiding this comment

b7011343 commented Nov 20, 2023

bionicode commented Nov 20, 2023

b7011343 commented Nov 21, 2023

Christoffyw commented Dec 18, 2023

Displee commented May 6, 2024

zly2006 commented May 14, 2024

phraktle commented Jul 4, 2024

realRobotix commented Jul 4, 2024

SpaiR commented Aug 4, 2024

kusaanko commented Aug 18, 2023 •

edited

Loading

zbx1425 commented Oct 25, 2023 •

edited

Loading