feat(api): add bindings for imgui-knobs #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bindings for the imgui-knobs extension
SpaiR
requested changes
Nov 28, 2023
There was a problem hiding this comment.
@1312Delta Looks good 👍 , but can you address styling issues I've mentioned?
imgui-binding/src/main/java/imgui/extension/imguiknobs/flag/ImGuiKnobFlags.java
Show resolved
Hide resolved
Update styling Co-authored-by: SpaiR <klimbetoo@gmail.com>
Update styling Co-authored-by: SpaiR <klimbetoo@gmail.com>
Remove gradle.properties from git ignore
Update styling, field names set to UPPER_CASE, remove throwing exceptions from constructors, refactored flags to general style
THCFree
approved these changes
Dec 23, 2023
THCFree
approved these changes
Dec 23, 2023
SpaiR
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings for the imgui-knobs extension
Description
Add jni bindings for the imgui-knobs extension and example window for it
Type of change