Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pointers casting type #265

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Change pointers casting type #265

merged 1 commit into from
Aug 29, 2024

Conversation

SpaiR
Copy link
Owner

@SpaiR SpaiR commented Aug 29, 2024 •
edited
Loading

  • uintptr_t is used instead of intptr_t to cast pointers.
  • Image methods now accept the long type instead of int, as they are expected to work with pointers as well.

resolves #185

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@SpaiR
feat(api): use uintptr_t instead of intptr_t for pointers
c2640d3 
Image methods now accept the `long` type instead of `int`,
as they are expected to work with pointers as well.
@SpaiR SpaiR added feat New feature or request api labels Aug 29, 2024
@SpaiR SpaiR merged commit c4c03be into main Aug 29, 2024
7 checks passed
@SpaiR SpaiR deleted the feat/pointers-handling branch August 29, 2024 13:54
@lwjglgamedev lwjglgamedev mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImGui.image() should expect long instead of int for textureId.
1 participant
@SpaiR